Use strings instead of chars in NumeralSystem#171
Merged
Conversation
MDLC01
changed the title
NumeralSystem::BijectiveNumeralSystem
isuffix
reviewed
May 29, 2026
Co-authored-by: isuffix <ian@isuffix.com>
isuffix
approved these changes
May 29, 2026
T0mstone
approved these changes
Jun 1, 2026
Collaborator
Author
|
Thank you both. I'll merge this this PR without waiting so that we can hopefully merge #170 before the next release. For the record, this is not a breaking change for Typst at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for #170 because the number five is represented by the string
"ه", which consists of two codepoints: <U+0647, U+200D>.I changed every numeral system that previously used
charto use&strinstead.